linux-kernel - Re: [PATCH] x86: early dump pci conf space v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080525223757.GA22343@colo.lackof.org>
Date:	Sun, 25 May 2008 16:37:57 -0600
From:	Grant Grundler <grundler@...isc-linux.org>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Grant Grundler <grundler@...isc-linux.org>,
	Ingo Molnar <mingo@...e.hu>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-pci@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: early dump pci conf space v2

On Thu, May 22, 2008 at 11:38:24PM -0700, Yinghai Lu wrote:
...
> > Having debugged lots of PCI resource and config issues, I understand
> > why this is useful and do NOT object to it being included in the tree.
> 
> could print out the setting from buggy BIOS, or first kernel.
> and don't need the reporter apply debug patch again...

Yes, I understood. Here are some more details on why my first
reaction was negative:
o Most of the time the system can boot anyway and we get lspci -v output,
  /proc/iomem, etc. If that's not true, then other parts of the kernel
  need to be more robust (e.g. drivers crashing because resources aren't
  assigned.

o Bringing up linux on a new platform is NOT something we've generally
  had to do via email. Usually someone with kernel/IO experience is
  involved and can build new kernels.

> > At least if you want people to use it. :)
> > Perhaps Jesse can suggest a preferred location.
> 
> we could add it.
> ..
> >
> > Please call this "pci_early_dump" (I prefer with underscores but don't care).
> > Don't want it confused with kernel dumps (LKCD) or any other
> > general debugging tools.
> 
> so you want pci_early_dump instead of pci=earlydump?
> or pci=early_dump?

Sorry, I misread the patch.
I was thinking of "pci_early_dump" as a seperate option but
either "pci=" option is fine.

thanks,
grant
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/