linux-kernel - Re: [PATCH] video4linux: Push down the BKL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0805251835520.25571@cnc.isely.net>
Date:	Sun, 25 May 2008 18:46:24 -0500 (CDT)
From:	Mike Isely <isely@...ly.net>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
cc:	Video4Linux list <video4linux-list@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Mike Isely at pobox <isely@...ox.com>
Subject: Re: [PATCH] video4linux: Push down the BKL

On Thu, 22 May 2008, Alan Cox wrote:

> For most drivers the generic ioctl handler does the work and we update it
> and it becomes the unlocked_ioctl method. Older drivers use the usercopy
> method so we make it do the work. Finally there are a few special cases.
> 
> Signed-off-by: Alan Cox <alan@...hat.com>

The pvrusb2 driver already should not require the BKL.  Though since 
this driver (like every V4L driver) is using video_usercopy() then it's 
obviously going along for the ride here with respect to the overall 
issue here in pushing the lock down into video_usercopy().  In the mean 
time, for the pvrusb2 portion of this patch...

Acked-By: Mike Isely <isely@...ox.com>

  -Mike

-- 

Mike Isely
isely @ pobox (dot) com
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/