linux-kernel - Re: [PATCH] MTD: fix 2 "unused variables" warnings in drivers/mtd/nand/cafe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080526115825.GA6722@Chamillionaire.breakpoint.cc>
Date:	Mon, 26 May 2008 13:58:26 +0200
From:	Sebastian Siewior <lkml@...breakpoint.cc>
To:	Toralf F?rster <toralf.foerster@....de>
Cc:	dwmw2@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]  MTD: fix 2 "unused variables" warnings  in
	drivers/mtd/nand/cafe_nand.c

* Toralf F?rster | 2008-05-26 13:47:51 [+0200]:

>--- a/drivers/mtd/nand/cafe_nand.c
>+++ b/drivers/mtd/nand/cafe_nand.c
>@@ -626,9 +626,7 @@ static int __devinit cafe_nand_probe(struct pci_dev *pdev,
> {
>        struct mtd_info *mtd;
>        struct cafe_priv *cafe;
>-       struct mtd_partition *parts;
>        uint32_t ctrl;
>-       int nr_parts;
>        int err = 0;
>
>        /* Very old versions shared the same PCI ident for all three
>@@ -800,6 +798,9 @@ static int __devinit cafe_nand_probe(struct pci_dev *pdev,
>        add_mtd_device(mtd);
>
> #ifdef CONFIG_MTD_PARTITIONS
>+       struct mtd_partition *parts;
>+       int nr_parts;
>+
You can't declare variables in the middle of the code, can you?

>        nr_parts = parse_mtd_partitions(mtd, part_probes, &parts, 0);
>        if (nr_parts > 0) {
>                cafe->parts = parts;

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/