linux-kernel - Re: [RFC PATCH 1/2] mmc_spi: export probe and remove functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 May 2008 14:18:36 +0200
From:	Pierre Ossman <drzeus-mmc@...eus.cx>
To:	Anton Vorontsov <avorontsov@...mvista.com>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Grant Likely <grant.likely@...retlab.ca>,
	Gary Jennejohn <garyj@...x.de>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/2] mmc_spi: export probe and remove functions

On Fri, 23 May 2008 22:28:34 +0400
Anton Vorontsov <avorontsov@...mvista.com> wrote:

> ...so we'll able to write bindings for the OpenFirmware without
> messing with #ifdefs in the driver itself.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>

This looks extremely wrong. Encapsulating probe functions isn't exactly
in line with the device model and bound to confuse people.

Your patches doesn't give a complete picture of the OF side of things,
but can't you solve this by having an init callback somewhere?

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/