linux-kernel - Re: [PATCH] video4linux: Push down the BKL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080526202317.GA12793@devserv.devel.redhat.com>
Date:	Mon, 26 May 2008 16:23:17 -0400
From:	Alan Cox <alan@...hat.com>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, video4linux-list@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video4linux: Push down the BKL

On Mon, May 26, 2008 at 01:59:51PM -0300, Mauro Carvalho Chehab wrote:
> cx18 and ivtv (see the attached log). Also, IMO, it would be better if you
> split drivers/net/tun.c into a different changeset.

That was most definitely not intended to be in the video patches 8)

> The next step can be to add the obvious locks inside video_ioctl2_unlocked(). Like, for
> example, locking the VIDIOC_S calls, if someone is calling the corresponding
> VIDIOC_G or VIDIOC_TRY ones.

Concentrate on the dats structures not the code - its one of those oft
quoted and very true rules - "lock data not code"

I'll tidy these up later in the week as I get time and merge them against
a current linux-next tree in bits with the rework done.

Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/