linux-kernel - Re: [2.6 patch] MIPS SEAD compile fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080526224342.GA28360@linux-mips.org>
Date:	Mon, 26 May 2008 23:43:42 +0100
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Adrian Bunk <adrian.bunk@...ial.fi>
Cc:	Chris Dearman <chris@...s.com>,
	Atsushi Nemoto <anemo@....ocn.ne.jp>,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] MIPS SEAD compile fix

On Sun, May 25, 2008 at 09:03:16PM +0300, Adrian Bunk wrote:

> This patch fixes the following compile error caused by
> commit 39b8d5254246ac56342b72f812255c8f7a74dca9
> ([MIPS] Add support for MIPS CMP platform.):
> 
> <--  snip  -->
> 
> ...
>   CC      arch/mips/mips-boards/generic/time.o
> cc1: warnings being treated as errors
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/mips-boards/generic/time.c:63: error: 'ledbitmask' defined but not used
> make[2]: *** [arch/mips/mips-boards/generic/time.o] Error 1
> 
> <--  snip  -->
> 
> Signed-off-by: Adrian Bunk <adrian.bunk@...ial.fi>
> 
> ---
> a6622e47dd128da338d6dbae457ec1b043604814 diff --git a/arch/mips/mips-boards/generic/time.c b/arch/mips/mips-boards/generic/time.c
> index 008fd82..df23558 100644
> --- a/arch/mips/mips-boards/generic/time.c
> +++ b/arch/mips/mips-boards/generic/time.c

[...]

> +#if defined(CONFIG_MIPS_MALTA) || defined(CONFIG_MIPS_ATLAS)

Generic code thanks to #ifdef ;-)  Not really the way to go.  I just blew
away the original offending change.

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/