linux-kernel - Re: [PATCH] hiddev: Switch to unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0805261053090.18218@twin.jikos.cz>
Date:	Mon, 26 May 2008 10:55:09 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
cc:	linux-kernel@...r.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-usb@...r.kernel.org, Oliver Neukum <oneukum@...e.de>
Subject: Re: [PATCH] hiddev: Switch to unlocked_ioctl

On Thu, 22 May 2008, Alan Cox wrote:

> Push down the BKL. In some cases compat_ioctl already doesn't take the
> BKL so we don't either. 

Thanks.

> @@ -555,7 +559,10 @@ static int hiddev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
>  	struct usbhid_device *usbhid = hid->driver_data;
>  	void __user *user_arg = (void __user *)arg;
>  	int i;
> +	
> +	/* Called without BKL by compat methods so no BKL taken */
>  
> +	/* FIXME: Who or what stop this racing with a disconnect ?? */
>  	if (!hiddev->exist)
>  		return -EIO;

Oliver (added to CC) -- I vaguely remember you already fixing this race, 
but I don't seem to be able to find the patch anywhere. Do I just remember 
incorrectly?

Thanks,

-- 
Jiri Kosina
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/