linux-kernel - Re: Linux 2.6.26-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <483BE87B.3030703@garzik.org>
Date:	Tue, 27 May 2008 06:54:51 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@....net>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jesper Krogh <jesper@...gh.cc>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: Linux 2.6.26-rc4

Carl-Daniel Hailfinger wrote:
> On 27.05.2008 12:35, Jeff Garzik wrote:
>> Carl-Daniel Hailfinger wrote:
>>> New code should look like
>>> static struct pci_device_id ck804xrom_pci_tbl[] = {
>>>     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0051), .driver_data =
>>> DEV_CK804 },
>>>     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0360), .driver_data =
>>> DEV_MCP55 },
>>>     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0361), .driver_data =
>>> DEV_MCP55 },
>>>     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0362), .driver_data =
>>> DEV_MCP55 },
>>>     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0363), .driver_data =
>>> DEV_MCP55 },
>>>     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0364), .driver_data =
>>> DEV_MCP55 },
>>>     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0365), .driver_data =
>>> DEV_MCP55 },
>>>     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0366), .driver_data =
>>> DEV_MCP55 },
>>>     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0367), .driver_data =
>>> DEV_MCP55 },
>>>     { 0, }
>>> };
>>
>> Actually, more like
>>
>>     { PCI_VDEVICE(NVIDIA, 0x0367), DEV_MCP55 },
> 
> AFAICS that would reintroduce the bug.

Look closely.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/