linux-kernel - Re: [PLEASE REVERT] "Add a WARN_ON_ONCE" at net/sched/sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080527.061442.193726441.davem@davemloft.net>
Date:	Tue, 27 May 2008 06:14:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	komurojun-mbn@...ty.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PLEASE REVERT] "Add a WARN_ON_ONCE" at
 net/sched/sch_generic.c:

From: Komuro <komurojun-mbn@...ty.com>
Date: Tue, 27 May 2008 21:34:24 +0900

> I think the transmit timeout indicates 
> that the cable is not connected or the irq is conflict.

The MAC of the chip transmits and ACKs the packet in the hardware even
if the link is down.  The packet is simply dropped.

Also, when the link goes down, the driver should mark the device as
such.  In such a state, the generic networking does not pass new
packets to the driver.

Therefore, transmit timeouts in this case are a hardware
or driver error.

If there is an IRQ issue, that is an error that'd we would like to
have as much information as possible to diagnose.  So the warning is
still entirely appropriate.

I sense that you are seeing this warning triggered, and if so I
would suggest that you investigate it fully as it should not be
happening under normal circumstances.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/