linux-kernel - Re: [PATCH 1/2] Added in MESSAGE notes for blktraces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 27 May 2008 15:32:06 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	"Alan D. Brunelle" <Alan.Brunelle@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-btrace@...r.kernel.org
Subject: Re: [PATCH 1/2] Added in MESSAGE notes for blktraces

On Tue, May 27 2008, Alan D. Brunelle wrote:
> +#define blk_add_trace_msg(q, fmt, ...)					\
> +	do {								\
> +		struct blk_trace *bt = (q)->blk_trace;			\
> +		if (unlikely(bt))					\
> +			__trace_note_message(bt, fmt, ##__VA_ARGS__);	\
> +	} while (0)
> +#define BLK_TN_MAX_MSG		1024

BTW, I think we need to make this a lot smaller. Something like 128
chars should be enough, I think. 1K is just too much stack size to use
here.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/