linux-kernel - Re: [PATCH] atmel_serial: Filter out FP during baud rate detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080527155248.1283eb58@hskinnemo-gx745.norway.atmel.com>
Date:	Tue, 27 May 2008 15:52:48 +0200
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	akpm@...ux-foundation.org
Cc:	linux@...im.org.za, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atmel_serial: Filter out FP during baud rate detection

Haavard Skinnemoen <haavard.skinnemoen@...el.com> wrote:
> I made a change to u-boot that used the FP (Fractional Part) field of
> BRGR to achieve more accurate baud rate generation. Unfortunately, the
> atmel_serial driver looks at the whole BRGR register when trying to
> detect the baud rate that the port is currently running at, so setting
> FP to a nonzero value breaks the baud rate detection.
> 
> I'll sit on the u-boot patch for a while longer, but this is clearly a
> bug in the atmel_serial driver which should be fixed.
> 
> Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@...el.com>

Oh, and before you ask: I think this should go into 2.6.26 and possibly
-stable as well. The sooner we get this into mainline, the sooner we
can start using fractional dividers in u-boot.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/