linux-kernel - Re: [PATCH resend] HTC Shift Touchscreen Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080527105118.ZZRA012@mailhub.coreip.homeip.net>
Date:	Tue, 27 May 2008 10:55:06 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	"Pau Oliva Fora (pof)" <pau@...ack.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH resend] HTC Shift Touchscreen Driver

Hi Pau,

I have couple more comments...

On Tue, May 27, 2008 at 04:46:03PM +0200, Pau Oliva Fora (pof) wrote:
> +
> +static void htcpen_close(struct input_dev *dev)
> +{
> +	free_irq(HTCPEN_IRQ, dev);

No, free_irq() should go into htcpen_remove(). Otherwise if we don't
unload the driver and open the device again we will not have IRQ
handler installed.

> +	outb_p(DEVICE_DISABLE, HTCPEN_PORT_INIT);
> +}
> +
> +static int __devinit htcpen_isa_probe(struct device *dev, unsigned int id)
> +{
> +	int err;
> +	struct input_dev *htcpen_dev;
> +
> +	inb_p(HTCPEN_PORT_IRQ_CLEAR);

You should not touch the ports until you resetved them with request
region.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/