linux-kernel - Re: [PATCH 3/8] debug printk infrastructure -compile fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080527144023.bf47e3e6.akpm@linux-foundation.org>
Date:	Tue, 27 May 2008 14:40:23 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jason Baron <jbaron@...hat.com>
Cc:	joe@...ches.com, greg@...ah.com, nick@...k-andrew.net,
	randy.dunlap@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] debug printk infrastructure -compile fixes

On Thu, 22 May 2008 17:16:39 -0400
Jason Baron <jbaron@...hat.com> wrote:

> 
> Signed-off-by: Jason Baron <jbaron@...hat.com>
> ---
>  net/netfilter/nf_conntrack_pptp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/netfilter/nf_conntrack_pptp.c b/net/netfilter/nf_conntrack_pptp.c
> index 97e54b0..7fea304 100644
> --- a/net/netfilter/nf_conntrack_pptp.c
> +++ b/net/netfilter/nf_conntrack_pptp.c
> @@ -65,7 +65,7 @@ void
>  			     struct nf_conntrack_expect *exp) __read_mostly;
>  EXPORT_SYMBOL_GPL(nf_nat_pptp_hook_expectfn);
>  
> -#ifdef DEBUG
> +#if defined(DEBUG) || defined(CONFIG_DYNAMIC_PRINTK_DEBUG)
>  /* PptpControlMessageType names */
>  const char *const pptp_msg_name[] = {
>  	"UNKNOWN_MESSAGE",

Does this imply that the patch series will break bisectability?  If so,
this fix should be merged into whichever patch introduces the build
breakage.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/