linux-kernel - Re: [PATCH take 3 29/29] UBIFS: include FS to compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080527220516.GD11310@cs181133002.pp.htv.fi>
Date:	Wed, 28 May 2008 01:05:16 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Adrian Hunter <ext-adrian.hunter@...ia.com>
Subject: Re: [PATCH take 3 29/29] UBIFS: include FS to compilation

On Mon, May 26, 2008 at 05:05:43PM +0300, Artem Bityutskiy wrote:
>...
> --- /dev/null
> +++ b/fs/ubifs/Kconfig
> @@ -0,0 +1,71 @@
> +config UBIFS_FS
> +	tristate "UBIFS file system support"
> +	select CRC16
> +	select CRC32
> +	depends on MTD_UBI
> +	help
> +	  UBIFS is a file system for flash devices which works on top of UBI.
>...
> +config UBIFS_FS_LZO
> +	bool "LZO compression support" if UBIFS_FS_ADVANCED_COMPR
> +	select CRYPTO
> +	select CRYPTO_LZO
> +	depends on UBIFS_FS
> +	default y
> +	help
> +	   LZO compressor is generally faster then zlib but compresses worse.
> +	   Say 'Y' if unsure.
>...

Please change this and similar other options to:

config UBIFS_FS
	tristate "UBIFS file system support"
	select CRC16
	select CRC32
	select CRYPTO if UBIFS_FS_LZO
	select CRYPTO_LZO if UBIFS_FS_LZO
	depends on MTD_UBI
...

config UBIFS_FS_LZO
	bool "LZO compression support" if UBIFS_FS_ADVANCED_COMPR
	depends on UBIFS_FS
...


This way UBIFS_FS=m, UBIFS_FS_LZO=y will only force CRYPTO_LZO=m and not 
CRYPTO_LZO=y.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/