linux-kernel - Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 May 2008 14:12:35 +0100
From:	David Howells <dhowells@...hat.com>
To:	Pekka J Enberg <penberg@...helsinki.fi>
Cc:	dhowells@...hat.com, clameter@....com, mpm@...enic.com,
	lethal@...ux-sh.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

Pekka J Enberg <penberg@...helsinki.fi> wrote:

> From: Christoph Lameter <clameter@....com>
> 
> As reported by Paul Mundt, kobjsize() does not work properly with SLOB and SLUB
> that re-use parts of struct page for their own purposes. Fix it up by using
> compound_order() for compound pages that don't have PageSlab set.
> 
> Reported-by: Paul Mundt <lethal@...ux-sh.org>
> Cc: Christoph Lameter <clameter@....com>
> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> ---
> I kept the original object size calculation for non-compound pages in this 
> version. It looks like the nommu code uses kobjsize() for all sorts of 
> interesting things.

Works for SLAB and SLUB.  SLOB breaks well before getting to anything these
patches affect.

Acked-by: David Howells <dhowells@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/