linux-kernel - Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 May 2008 23:03:17 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Paul Mundt <lethal@...ux-sh.org>,
	LKML <linux-kernel@...r.kernel.org>, cooloney@...nel.org
CC:	akpm@...ux-foundation.org, dhowells@...hat.com, mpm@...enic.com,
	clameter@....com
Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

(cc'ing linux-kernel)

Paul Mundt wrote:
> I have no idea why you are maintaining the page->index case here, it's
> completely broken for page cache pages. Unless someone more familiar with
> the page->index BUG_ON() tests objects, the BUG_ON() there should be
> removed completely. Neither Christoph nor I were able to work out what the
> point of the page->index tests were, and no one else has spoken up about
> them, so it's likely safe to treat them as bogus.

We use kobjsize() for pointers returned from do_mmap() which is why I 
kept the page->index case. Are we using PageCompound for those as well?

Paul Mundt wrote:
> SLOB on nommu will oops on any page cache page in the current git kernels
> until those BUG_ON()'s are killed. The more distressing thing is the fact
> that the blackfin people have been patching SLOB when it's obvious that
> they haven't been testing (ie, even booting!) it.

Hmm...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/