linux-kernel - Re: [PATCH] atmel_serial: Filter out FP during baud rate detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080528090409.3f26878b@hskinnemo-gx745.norway.atmel.com>
Date:	Wed, 28 May 2008 09:04:09 +0200
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	"Andrew Victor" <avictor.za@...il.com>
Cc:	akpm@...ux-foundation.org, linux@...im.org.za,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atmel_serial: Filter out FP during baud rate detection

"Andrew Victor" <avictor.za@...il.com> wrote:
> > I made a change to u-boot that used the FP (Fractional Part) field of
> > BRGR to achieve more accurate baud rate generation. Unfortunately, the
> > atmel_serial driver looks at the whole BRGR register when trying to
> > detect the baud rate that the port is currently running at, so setting
> > FP to a nonzero value breaks the baud rate detection.
> 
> > Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
> 
> Acked-by: Andrew Victor <linux@...im.org.za>

Thanks.

> The FP (Fractional Part) is not supported on some AT91 processors
> (RM9200, SAM9261) though.
> Those bits in BRGR are undefined.

Yes...I guess that's one more reason to filter them out.

FWIW, the u-boot patch explicitly excludes those two processors,
falling back to the existing CD calculation code.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/