linux-kernel - Re: BUG/OOPS: Double Lock in fsl_usb2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1212058093.5068.1.camel@Gundam>
Date:	Thu, 29 May 2008 18:48:13 +0800
From:	Li Yang <leoli@...escale.com>
To:	David Brownell <david-b@...bell.net>
Cc:	Eugene_Bordenkircher@...inc.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: BUG/OOPS: Double Lock in fsl_usb2_udc.c

On Thu, 2008-05-29 at 02:23 -0700, David Brownell wrote:
> > On Wed, 28 May 2008 15:25:31 -0700 Eugene_Bordenkircher@...inc.com wrote:
> > 
> > > Looking through other drivers, I have seen them releasing the lock 
> > > immediately before calling disconnect(), however, without being an expert 
> > > with this driver, I'm not entirely sure that is the best option here. 
> 
> Yeah, general policy is to drop the UDC spinlock whenever
> you call out to gadget driver code, since it may need to
> reenter for various reasons.  (Though if drivers adopt some
> other locking policy that works, that should be fine too.
> Multiple locks don't seem to be needed.)
> 

I will submit a patch to release the lock before calling disconnect().

- Leo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/