linux-kernel - Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <483E946B.8010908@aitel.hist.no>
Date:	Thu, 29 May 2008 13:32:59 +0200
From:	Helge Hafting <helge.hafting@...el.hist.no>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	ksummit-2008-discuss@...ts.linux-foundation.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project

James Bottomley wrote:
[...]
> track down, the last thing I want to see within a million miles of my
> inbox is a white space fixing patch.  The more of these patches we get,
> the worse the problem becomes and the shorter and more inflammatory the
> responses get. We can't go on like this.
> 
This particular problem seems fixable. Put something like this in the 
janitor faq:

"Don't create patches that are whitespace-fixes, or similiar attempts to
make the kernel adhere to the CodingStyle without actually changing the 
working code. The reasons are:
* Any patch disturbs others working on the same file. So change must be
   justified by usefulness above mere pretty formatting.
* The maintainer can run the code through pretty-printing software
   _when it won't disrupt other activity_. Such software will do
   a better cleanup job than you can, and with no human effort at.
Please find something more useful to do than whitespace/style
improvements on existing code."

And if they do this anyway, just reject the patch with a pointer to the 
FAQ entry...

Helge Hafting

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/