linux-kernel - Re: [PATCH 2/4] ipc/sem.c: remove unused entries from struct sem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 May 2008 17:02:14 +0200
From:	Nadia Derbey <Nadia.Derbey@...l.net>
To:	Manfred Spraul <manfred@...orfullife.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] ipc/sem.c: remove unused entries from struct sem_queue

Manfred Spraul wrote:
> sem_queue.sma and sem_queue.id were never used, the attached
> patch removes them.
> 
> Signed-Off-By: Manfred Spraul <manfred@...orfullife.com>

Reviewed-By: Nadia Derbey <Nadia.Derbey@...l.net>

> ---
>  include/linux/sem.h |    2 --
>  ipc/sem.c           |    2 --
>  2 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/sem.h b/include/linux/sem.h
> index 6a1af1b..87756ef 100644
> --- a/include/linux/sem.h
> +++ b/include/linux/sem.h
> @@ -107,8 +107,6 @@ struct sem_queue {
>  	struct sem_undo *	undo;	 /* undo structure */
>  	int    			pid;	 /* process id of requesting process */
>  	int    			status;	 /* completion status of operation */
> -	struct sem_array *	sma;	 /* semaphore array for operations */
> -	int			id;	 /* internal sem id */
>  	struct sembuf *		sops;	 /* array of pending operations */
>  	int			nsops;	 /* number of operations */
>  	int			alter;   /* does the operation alter the array? */
> diff --git a/ipc/sem.c b/ipc/sem.c
> index 211632e..8cd96f1 100644
> --- a/ipc/sem.c
> +++ b/ipc/sem.c
> @@ -1160,12 +1160,10 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
>  	 * task into the pending queue and go to sleep.
>  	 */
>  		
> -	queue.sma = sma;
>  	queue.sops = sops;
>  	queue.nsops = nsops;
>  	queue.undo = un;
>  	queue.pid = task_tgid_vnr(current);
> -	queue.id = semid;
>  	queue.alter = alter;
>  	if (alter)
>  		append_to_queue(sma ,&queue);



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/