linux-kernel - [patch] removes casting of (void*) private structure members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805291933.54529@marek.priv.at>
Date:	Thu, 29 May 2008 19:33:54 +0200
From:	Philipp Marek <philipp@...ek.priv.at>
To:	linux-trivial@...nel.org
Cc:	linux-kernel@...r.kernel.org
Subject: [patch] removes casting of (void*) private structure members

Hello everybody,

here's another trivial patch, against v2.6.26-rc3-243-gd40ace0.


It's compile tested, but not entirely checkpatch-clean:
	ERROR: code indent should use tabs where possible
	#3296: FILE: drivers/s390/net/lcs.c:1289:
	+        card = dev->priv;$

	ERROR: code indent should use tabs where possible
	#3363: FILE: drivers/s390/net/claw.c:1012:
	+        privptr = dev->priv;$

	ERROR: code indent should use tabs where possible
	#3372: FILE: drivers/s390/net/claw.c:1047:
	+        privptr = dev->priv;$

	ERROR: code indent should use tabs where possible
	#3540: FILE: drivers/s390/block/dasd_eckd.c:168:
	+        private = device->private;$

	total: 4 errors, 0 warnings, 4451 lines checked


I don't think it's a good idea to change the indent of single
lines just because of this warnings, that's why I let them as-is.

The script can be downloaded from
  http://kernelnewbies.org/KernelJanitors/Todo/VoidPointerConvs


diffstat | sort -k3 -n (and removed files with < 20 lines):
 ...
drivers/net/atarilance.c                     |   20 +++---
 net/atm/lec.c                                |   20 +++---
 drivers/net/ni52.c                           |   22 +++----
 drivers/net/3c523.c                          |   24 +++----
 drivers/net/mace.c                           |   24 +++----
 drivers/net/sun3_82586.c                     |   24 +++----
 drivers/net/ni65.c                           |   26 ++++----
 drivers/net/dm9000.c                         |   28 ++++-----
 drivers/s390/block/dasd_alias.c              |   28 ++++-----
 drivers/net/depca.c                          |   30 ++++-----
 drivers/message/i2o/i2o_proc.c               |   38 ++++++------
 drivers/s390/block/dasd_eckd.c               |   42 ++++++-------
 drivers/net/au1000_eth.c                     |   46 +++++++-------
 drivers/net/wan/sbni.c                       |   50 ++++++++--------
 drivers/net/wireless/zd1201.c                |   62 +++++++++----------
 drivers/net/wireless/wavelan.c               |   84 +++++++++++++--------------
 112 files changed, 553 insertions(+), 558 deletions(-)


There are some private structure variables that are not defined as (void*),
(but int or long) and cannot be done without a cast; examples in
	drivers/char/hw_random/intel-rng.c
	drivers/crypto/hifn_795x.c
	drivers/mtd/mtdblock.c
	drivers/mtd/mtdoops.c
	drivers/mtd/rfd_ftl.c
	fs/jffs2/erase.c

Should these be converted to (void*), and an additional patch supplied?


Regards,

Phil


-- 
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!

View attachment "voidp_vars.patch" of type "text/x-diff" (172166 bytes)