linux-kernel - Re: [BUG ?] kmalloc() with GFP_KERNEL while holding spinlock ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fxs1rcag.fsf@saeurebad.de>
Date:	Thu, 29 May 2008 05:59:03 +0200
From:	Johannes Weiner <hannes@...urebad.de>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Jeff Garzik <jeff@...zik.org>, Tejun Heo <htejun@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-ide@...r.kernel.org
Subject: Re: [BUG ?] kmalloc() with GFP_KERNEL while holding spinlock ?

Hi,

Li Zefan <lizf@...fujitsu.com> writes:

> I noticed the following issue in the code:
>
> in drivers/ata/libata-acpi.c:
>
> static void ata_acpi_handle_hotplug(struct ata_port *ap, struct ata_device *dev,
> 				    u32 event)
> {
> 	...
> 	spin_lock_irqsave(ap->lock, flags);
> 	...
>
> 	if (dev) {
> 		if (dev->sdev)
> 			kobj = &dev->sdev->sdev_gendev.kobj;
> 	} else
> 		kobj = &ap->dev->kobj;
>
> 	if (kobj) {
> 		sprintf(event_string, "BAY_EVENT=%d", event);
> 		kobject_uevent_env(kobj, KOBJ_CHANGE, envp);
> 	}
>
> 	spin_unlock_irqrestore(ap->lock, flags);
> 	...
> }
>
> and kobject_uevent_env() calls kzalloc(..., GFP_KERNEL);

Fixed by commit ae6c23c4e1ec9720b99e1e6850fe47c6c7fddbb3 "Fixups to ATA
ACPI hotplug" by Matthew Garrett.

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/