linux-kernel - Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 May 2008 14:29:24 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Mike Frysinger <vapier.adi@...il.com>
cc:	David Howells <dhowells@...hat.com>,
	Pekka J Enberg <penberg@...helsinki.fi>, mpm@...enic.com,
	lethal@...ux-sh.org, linux-kernel@...r.kernel.org,
	Bryan Wu <cooloney@...nel.org>
Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

On Thu, 29 May 2008, Mike Frysinger wrote:

> > You should not have to do this. This is the default alignment that also
> > SLOB needs to follow. We need to align structures correctly for access to
> > long long's.
> 
> are you saying that slob is broken ?  i see in mm/slob.c:
> #ifndef ARCH_KMALLOC_MINALIGN
> #define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long)
> #endif
> -mike

It should be long long instead.

SLUB:

#ifndef ARCH_KMALLOC_MINALIGN
#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long)
#endif

SLAB:

#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long)
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/