linux-kernel - Re: [PATCH 14/40] ide-floppy: merge idefloppy_transfer_pc() and idefloppy_transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200805300101.14495.bzolnier@gmail.com>
Date:	Fri, 30 May 2008 01:01:13 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	petkovbb@...il.com
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/40] ide-floppy: merge idefloppy_transfer_pc() and idefloppy_transfer_pc1()

On Tuesday 27 May 2008, Borislav Petkov wrote:
> On Tue, May 27, 2008 at 08:57:42PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Wednesday 21 May 2008, Borislav Petkov wrote:
> > > On Sun, May 18, 2008 at 08:56:33PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > > > * Check IDEFLOPPY_FLAG_ZIP_DRIVE flag in idefloppy_transfer_pc1()
> > > >   and skip idefloppy_transfer_pc2()-phase if the flag is not set.
> > > > 
> > > > * Always use idefloppy_transfer_pc1() in idefloppy_issue_pc()
> > > >   and remove no longer needed idefloppy_transfer_pc().
> > > 
> > > ... and also probably mv idefloppy_transfer_pc1() to something like
> > > idefloppy_start_transfer_pc() and rename idefloppy_transfer_pc2() to something
> > > more appropriate like e.g. idefloppy_do_transfer_pc() or similar and do away
> > > with those misleading names and probably even the comments are superfluous then.
> > 
> > Probably the most intuitive would be to do:
> > 
> > 	idefloppy_transfer_pc1() -> idefloppy_transfer_pc()
> > 
> > and
> > 
> > 	idefloppy_transfer_pc2() -> idefloppy_do_transfer_pc()
> > 
> > but I don't feel too strong about it and welcome other ideas
> > (preferably in form of patches :).
> 
> ^Hint^! :) Sure, what about the following:
> --
> 
> From: Borislav Petkov <petkovbb@...il.com>
> Date: Tue, 27 May 2008 07:31:37 +0200
> Subject: [PATCH] ide-floppy: fix unfortunate function naming
> 
> mv idefloppy_transfer_pc1 idefloppy_start_pc_transfer
> mv idefloppy_transfer_pc2 idefloppy_transfer_pc
> 
> which describes their functionality and disambiguates them. There should be no
> functionality change introduced by this patch.
> 
> Signed-off-by: Borislav Petkov <petkovbb@...il.com>

applied, thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/