linux-kernel - Re: RESEND: [PATCH 2/3] ACPI: Send switch event on dock events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080528223225.51cf8298.akpm@linux-foundation.org>
Date:	Wed, 28 May 2008 22:32:25 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	linux-input@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, kristen.c.accardi@...el.com
Subject: Re: RESEND: [PATCH 2/3] ACPI: Send switch event on dock events

On Wed, 28 May 2008 14:33:49 +0100 Matthew Garrett <mjg59@...f.ucam.org> wrote:

> Send a switch event on docking for consistency with docks that don't 
> present as a separate device.
> 
> Signed-off-by: Matthew Garrett <mjg@...hat.com>
> 
> ---
> 
> diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
> index fa44fb9..a67e74c 100644
> --- a/drivers/acpi/dock.c
> +++ b/drivers/acpi/dock.c
> @@ -25,6 +25,7 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/init.h>
> +#include <linux/input.h>
>  #include <linux/types.h>
>  #include <linux/notifier.h>
>  #include <linux/platform_device.h>
> @@ -65,6 +66,7 @@ struct dock_station {
>  	struct mutex hp_lock;
>  	struct list_head dependent_devices;
>  	struct list_head hotplug_devices;
> +	struct input_dev *dock_input;
>  };
>  
>  struct dock_dependent_device {
> @@ -345,10 +347,13 @@ static void dock_event(struct dock_station *ds, u32 event, int num)
>  	char event_string[13];
>  	char *envp[] = { event_string, NULL };
>  
> -	if (num == UNDOCK_EVENT)
> +	if (num == UNDOCK_EVENT) {
> +		input_report_switch(dock_station->dock_input, SW_DOCK, 0);

Is CONFIG_ACPI_DOCK=y, CONFIG_INPUT=n possible?  I think so..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/