linux-kernel - Re: [patch 26/41] cpu alloc: Convert mib handling to cpu alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <483FA30F.2050900@cosmosbay.com>
Date:	Fri, 30 May 2008 08:47:43 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Christoph Lameter <clameter@....com>
Cc:	akpm@...ux-foundation.org, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>,
	Peter Zijlstra <peterz@...radead.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Mike Travis <travis@....com>
Subject: Re: [patch 26/41] cpu alloc: Convert mib handling to cpu alloc

Christoph Lameter a écrit :
> Use the cpu alloc functions for the mib handling functions in the net
> layer. The API for snmp_mib_free() is changed to add a size parameter
> since cpu_free() requires a size parameter.
>
> Signed-off-by: Christoph Lameter <clameter@....com>
> ---
>  include/net/ip.h     |    2 +-
>  include/net/snmp.h   |   32 ++++++++------------------------
>  net/dccp/proto.c     |    2 +-
>  net/ipv4/af_inet.c   |   31 +++++++++++++++++--------------
>  net/ipv6/addrconf.c  |   11 ++++++-----
>  net/ipv6/af_inet6.c  |   20 +++++++++++---------
>  net/sctp/protocol.c  |    2 +-
>  net/xfrm/xfrm_proc.c |    4 ++--
>  8 files changed, 47 insertions(+), 57 deletions(-)
>   
We also can avoid the use of two arrays when CONFIG_HAVE_CPU_OPS
since _CPU_INC() and __CPU_INC() are both interrupt safe.
This would reduce size of mibs by 50% and complexity (no need to sum)




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/