linux-kernel - Re: drivers/watchdog/geodewdt.c: build fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 May 2008 09:39:19 -0600
From:	Jordan Crouse <jordan.crouse@....com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Wim Van Sebroeck <wim@...ana.be>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Samuel Tardieu <sam@...1149.net>,
	Mike Frysinger <vapier.adi@...il.com>,
	Mingarelli@...omag.iguana.be, Thomas <Thomas.Mingarelli@...com>,
	Chen Gong <g.chen@...escale.com>,
	Gabriel C <nix.or.die@...glemail.com>
Subject: Re: drivers/watchdog/geodewdt.c: build fix

On 30/05/08 17:02 +0200, Ingo Molnar wrote:
> 
> * Wim Van Sebroeck <wim@...ana.be> wrote:
> 
> > Author: Jordan Crouse <jordan.crouse@....com>
> > Date:   Mon Jan 21 10:07:00 2008 -0700
> > 
> >     [WATCHDOG] Add a watchdog driver based on the CS5535/CS5536 MFGPT timers
> 
> -tip testing found the following build failure on latest -git:
> 
>   drivers/watchdog/geodewdt.c: In function 'geodewdt_probe':
>   drivers/watchdog/geodewdt.c:225: error: too many arguments to function 'geode_mfgpt_alloc_timer'
>   make[1]: *** [drivers/watchdog/geodewdt.o] Error 1
>   make: *** [drivers/watchdog/geodewdt.o] Error 2
> 
> with this config:
> 
>   http://redhat.com/~mingo/misc/config-Fri_May_30_15_19_52_CEST_2008.bad
> 
> find the fix below.
> 
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
Acked-by: Jordan Crouse <jordan.crouse@....com>

> ---
>  drivers/watchdog/geodewdt.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Index: tip/drivers/watchdog/geodewdt.c
> ===================================================================
> --- tip.orig/drivers/watchdog/geodewdt.c
> +++ tip/drivers/watchdog/geodewdt.c
> @@ -221,8 +221,7 @@ geodewdt_probe(struct platform_device *d
>  {
>  	int ret, timer;
>  
> -	timer = geode_mfgpt_alloc_timer(MFGPT_TIMER_ANY,
> -					MFGPT_DOMAIN_WORKING, THIS_MODULE);
> +	timer = geode_mfgpt_alloc_timer(MFGPT_TIMER_ANY, MFGPT_DOMAIN_WORKING);
>  
>  	if (timer == -1) {
>  		printk(KERN_ERR "geodewdt:  No timers were available\n");
> 

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/