linux-kernel - Re: [RFC] [PATCH 1/2] cpusets: restructure the function update_cpumask() and update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080529203042.19f76f09.rdunlap@xenotime.net>
Date:	Thu, 29 May 2008 20:30:42 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Paul Jackson <pj@....com>
Cc:	miaox@...fujitsu.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, menage@...gle.com
Subject: Re: [RFC] [PATCH 1/2] cpusets: restructure the function
 update_cpumask() and update_nodemask()

On Thu, 29 May 2008 21:22:11 -0500 Paul Jackson wrote:

> Miao wrote:
> > I check kernel/cpuset.c and find many static functions with "/**" comment.
> > So I want to remove the special commenting convention for them.
> 
> Right you are.  Offhand, in kernel/cpuset.c, I see:
> 
>     static int cpuset_test_cpumask(struct task_struct *tsk,
>     static void cpuset_change_cpumask(struct task_struct *tsk,
>     static int update_cpumask(struct cpuset *cs, char *buf)
>     static void cpuset_do_move_task(struct task_struct *tsk,
>     static void move_member_tasks_to_cpuset(struct cpuset *from, struct cpuset *to)
> 
> all having "/**" header comments.  I would be glad to Ack a patch
> from you to fix such comments.  Thank-you.


Uh.. We strongly want non-static functions to be documented via kernel-doc.
For static functions, it's up to the maintainer/developer whether to do that
or not.  But if the functions already have kernel-doc, there's no strong
reason to remove it.  And these look good currently, so I see no
good reason to change them.



---
~Randy
"He closes his eyes and drops the goggles.  You can't get hurt
by looking at a bitmap.  Or can you?"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/