linux-kernel - Re: [patch 8/8] vfs: create file_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080531082934.GG24135@infradead.org>
Date:	Sat, 31 May 2008 04:29:34 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	linux-fsdevel@...r.kernel.org, hch@...radead.org,
	viro@...IV.linux.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [patch 8/8] vfs: create file_remove_suid() helper

On Thu, May 29, 2008 at 01:32:53PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@...e.cz>
> 
> All calls to remove_suid() are made with a file pointer.  This is not
> accidental: similarly to file_update_time(), this function is called
> when the file is written.
> 
> So simplify callers by passing the file pointer instead of the dentry.

It's not simplifying anything at all.  You just move the pointer
derefence down one step the callchain without any need.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/