linux-kernel - Re: [patch 1/2] MTD: use list_for_each_entry() in add_mtd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080531194154.GA7055@logfs.org>
Date:	Sat, 31 May 2008 21:41:55 +0200
From:	Jörn Engel <joern@...fs.org>
To:	Matthias Kaehlcke <matthias@...hlcke.net>
Cc:	dwmw2@...radead.org, linux-mtd@...ts.infradead.org,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Chris Malley <mail@...ismalley.co.uk>
Subject: Re: [patch 1/2] MTD: use list_for_each_entry() in add_mtd_device()

On Sat, 31 May 2008 15:35:11 +0200, Matthias Kaehlcke wrote:
> 
> MTD: use list_for_each_entry() instead of list_for_each() in add_mtd_device()
> 
> Signed-off-by: Matthias Kaehlcke <matthias@...hlcke.net>

Chris Malley (added to Cc:) sent a patch converting all of drivers/mtd/
in a similar fashion.  It should be on its way in, if dwmw2 hasn't
missed it.

You might also want to check your mailer.  This patch looks like bouquet
of flowers that got stuck in an elevator door. ;)

> Index: linux-2.6/drivers/mtd/mtdcore.c
> ===================================================================
> --- linux-2.6.orig/drivers/mtd/mtdcore.c        2008-05-31
> 15:31:17.000000000 +0200
> +++ linux-2.6/drivers/mtd/mtdcore.c     2008-05-31 15:32:19.000000000
> +0200
> @@ -53,7 +53,7 @@
> 
>         for (i=0; i < MAX_MTD_DEVICES; i++)
>                 if (!mtd_table[i]) {
> -                       struct list_head *this;
> +                       struct mtd_notifier *not;
> 
>                         mtd_table[i] = mtd;
>                         mtd->index = i;
> @@ -72,8 +72,7 @@
>                         DEBUG(0, "mtd: Giving out device %d to
> 												%s\n",i, mtd->name);
>                         /* No need to get a refcount on the module
> 												containing
>                            the notifier, since we hold the
> 													 mtd_table_mutex */
> -                       list_for_each(this, &mtd_notifiers) {
> -                               struct mtd_notifier *not =
> list_entry(this, struct mtd_notifier, list);
> +                       list_for_each_entry(not, &mtd_notifiers, list)
> {
>                                 not->add(mtd);
>                         }

Jörn

-- 
You ain't got no problem, Jules. I'm on the motherfucker. Go back in
there, chill them niggers out and wait for the Wolf, who should be
coming directly.
-- Marsellus Wallace
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/