linux-kernel - Re: [PATCH] x86: fix pointer type warning in arch/x86/mm/init_64.c:early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 30 May 2008 17:56:24 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Kevin Winchester" <kjwinchester@...il.com>
Cc:	"Ingo Molnar" <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	"Thomas Gleixner" <tglx@...utronix.de>
Subject: Re: [PATCH] x86: fix pointer type warning in arch/x86/mm/init_64.c:early_memtest

On Fri, May 30, 2008 at 5:34 PM, Kevin Winchester
<kjwinchester@...il.com> wrote:
> Kevin Winchester wrote:
>>
>> Changed the call to find_e820_area_size to pass u64 instead of unsigned
>> long.
>>
>> Signed-off-by: Kevin Winchester <kjwinchester@...il.com>
>> ---
>>  arch/x86/mm/init_64.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index 83ab7f9..94f73c2 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -515,7 +515,7 @@ early_param("memtest", parse_memtest);
>>   static void __init early_memtest(unsigned long start, unsigned long end)
>>  {
>> -       unsigned long t_start, t_size;
>> +       u64 t_start, t_size;
>>        unsigned pattern;
>>          if (!memtest_pattern)
>> @@ -534,7 +534,7 @@ static void __init early_memtest(unsigned long start,
>> unsigned long end)
>>                        if (t_start + t_size > end)
>>                                t_size = end - t_start;
>>  -                       printk(KERN_CONT "\n  %016lx - %016lx pattern
>> %d",
>> +                       printk(KERN_CONT "\n  %016llx - %016llx pattern
>> %d",
>>                                t_start, t_start + t_size, pattern);
>>                          memtest(t_start, t_size, pattern);
>
> I still see this warning on next-20080530 - so I expanded the CC list a
> little.  Did I do this patch right?

i had one in local too.

Acked-by: Yinghai Lu <yhlu.kernel@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/