linux-kernel - Re: [patch 2/8] vfs: fix sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080531082052.GC24135@infradead.org>
Date:	Sat, 31 May 2008 04:20:52 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	linux-fsdevel@...r.kernel.org, hch@...radead.org,
	viro@...IV.linux.org.uk, linux-kernel@...r.kernel.org,
	John Johansen <jjohansen@...e.de>
Subject: Re: [patch 2/8] vfs: fix sys_getcwd for detached mounts

On Thu, May 29, 2008 at 01:32:47PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@...e.cz>
> 
> Currently getcwd(2) on a detached mount will give a garbled result:
> 
>    > mkdir /mnt/foo
>    > mount --bind /etc /mnt/foo
>    > cd /mnt/foo/skel
>    > /bin/pwd
>    /mnt/foo/skel
>    > umount -l /mnt/foo
>    > /bin/pwd
>    etcskel
> 
> After the patch it will give a much saner "/skel" result.
> 
> Thanks to John Johansen for pointing out this bug.

I'm not sure just cuttinig of the prefix is perfect, but the previous
behvaiour is obviously completely wrong, and the change is simple
enough.  So okay from me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/