linux-kernel - [PATCH] coredump: binfmt_elf{,_fdpic}.c: don't abuse GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080601165506.GA8880@tv-sign.ru>
Date:	Sun, 1 Jun 2008 20:55:06 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	David Howells <dhowells@...hat.com>, linux-kernel@...r.kernel.org
Subject: [PATCH] coredump: binfmt_elf{,_fdpic}.c: don't abuse GFP_ATOMIC

kmalloc(GFP_ATOMIC) was needed because it was called under tasklist_lock.
The code was changed to use rcu_read_lock(), we can use GFP_KERNEL.

Signed-off-by: Oleg Nesterov <oleg@...sign.ru>

 binfmt_elf.c       |    4 ++--
 binfmt_elf_fdpic.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

--- 26-rc2/fs/binfmt_elf.c~NO_ATOMIC	2008-05-18 15:43:59.000000000 +0400
+++ 26-rc2/fs/binfmt_elf.c	2008-06-01 20:47:08.000000000 +0400
@@ -1524,7 +1524,7 @@ static int fill_note_info(struct elfhdr 
 		if (p->mm == dump_task->mm) {
 			t = kzalloc(offsetof(struct elf_thread_core_info,
 					     notes[info->thread_notes]),
-				    GFP_ATOMIC);
+				    GFP_KERNEL);
 			if (unlikely(!t)) {
 				rcu_read_unlock();
 				return 0;
@@ -1726,7 +1726,7 @@ static int fill_note_info(struct elfhdr 
 		rcu_read_lock();
 		do_each_thread(g, p)
 			if (current->mm == p->mm && current != p) {
-				ets = kzalloc(sizeof(*ets), GFP_ATOMIC);
+				ets = kzalloc(sizeof(*ets), GFP_KERNEL);
 				if (!ets) {
 					rcu_read_unlock();
 					return 0;
--- 26-rc2/fs/binfmt_elf_fdpic.c~NO_ATOMIC	2008-05-18 15:43:59.000000000 +0400
+++ 26-rc2/fs/binfmt_elf_fdpic.c	2008-06-01 20:47:20.000000000 +0400
@@ -1626,7 +1626,7 @@ static int elf_fdpic_core_dump(long sign
 		rcu_read_lock();
 		do_each_thread(g,p)
 			if (current->mm == p->mm && current != p) {
-				tmp = kzalloc(sizeof(*tmp), GFP_ATOMIC);
+				tmp = kzalloc(sizeof(*tmp), GFP_KERNEL);
 				if (!tmp) {
 					rcu_read_unlock();
 					goto cleanup;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/