linux-kernel - Re: [patch 09/15] PNP: make resource assignment functions return 0 (success) or -EBUSY (failure)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48431BAA.4040902@keyaccess.nl>
Date:	Sun, 01 Jun 2008 23:59:06 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
CC:	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Adam Belay <ambx1@....rr.com>,
	Adam M Belay <abelay@....edu>,
	Li Shaohua <shaohua.li@...el.com>,
	Matthieu Castet <castet.matthieu@...e.fr>,
	Thomas Renninger <trenn@...e.de>,
	Jaroslav Kysela <perex@...ex.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Takashi Iwai <tiwai@...e.de>
Subject: Re: [patch 09/15] PNP: make resource assignment functions return
 0 (success) or -EBUSY (failure)

On 31-05-08 00:49, Bjorn Helgaas wrote:

> This patch doesn't change any behavior; it just makes the return
> values more conventional.
> 
> This changes pnp_assign_dma() from a void function to one that
> returns an int, just like the other assignment functions.  For
> now, at least, pnp_assign_dma() always returns 0 (success), so
> it appears to never fail, just like before.
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@...com>

Acked-by: Rene Herman <rene.herman@...il.com>

I believe it would a bit nicer to (as long as we're pretending it 
matters in the first place) pass the return value back up from 
pnp_check_foo() instead of returning -EBUSY always but <shrug>

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/