linux-kernel - Re: [PATCH] drm: make drm use create_proc_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080601093600.GL28946@ZenIV.linux.org.uk>
Date:	Sun, 1 Jun 2008 10:36:00 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Arjan van de Ven <arjan@...radead.org>, airlied@...ux.ie,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: make drm use create_proc_read_entry() instead

On Sun, Jun 01, 2008 at 01:25:46PM +0400, Alexey Dobriyan wrote:
> On Sat, May 31, 2008 at 09:48:21PM -0700, Arjan van de Ven wrote:
> > Subject: [PATCH] drm: make drm use create_proc_read_entry() instead
> > 
> > Al Viro points out that DRM should have used create_proc_read_entry(),
> > and although that is still racey right now, it at least has a chance
> > of getting fixed on the api level.
> 
> Fix on API level is proc_create_data(), so this patch is pointless.

Yeah...  OTOH, it might make sense to reorder assignments in the
create_proc_read_entry() and slap the barrier in there - it would
close at least some of the holes until we get around to proper
proc_create_data() conversions and remove the ->read_proc() crap...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/