linux-kernel - Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080601102401.GD25429@linux-sh.org>
Date:	Sun, 1 Jun 2008 19:24:01 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Pekka J Enberg <penberg@...helsinki.fi>
Cc:	David Howells <dhowells@...hat.com>,
	Christoph Lameter <clameter@....com>,
	LKML <linux-kernel@...r.kernel.org>, cooloney@...nel.org,
	akpm@...ux-foundation.org, mpm@...enic.com
Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

On Sun, Jun 01, 2008 at 12:13:02PM +0300, Pekka J Enberg wrote:
> Hi Paul,
> 
> On Sun, 1 Jun 2008, Paul Mundt wrote:
> > This still needs to be virt_to_head_page() I think.
> > 
> > I don't have my nommu boards at home, so I'll test at the office tomorow
> > morning and let you know.
> 
> I was about to send a patch that fixes some of the kobjsize() abuses to 
> use ksize() but then I realized that what we probably should do is 
> something like this instead.
> 
> I mean, assuming the BUG_ON bits are bogus, then we should always pass the 
> pointer to the allocator. I audited most of the callers and they all seem 
> to be really just using kmalloc() for allocation anyway.
> 
> What do you think?
> 
Isn't this what my original patch did? ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/