linux-kernel - Re: [PATCH] softlockup: fix NMI hangs due to lock race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080602103931.GA898@elte.hu>
Date:	Mon, 2 Jun 2008 12:39:31 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jason Wessel <jason.wessel@...driver.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	a.p.zijlstra@...llo.nl
Subject: Re: [PATCH] softlockup: fix NMI hangs due to lock race - 2.6.26-rc
	regression


* Jason Wessel <jason.wessel@...driver.com> wrote:

> The touch_nmi_watchdog() routine on x86 ultimately calls 
> touch_softlockup_watchdog().  The problem is that to touch the 
> softlockup watchdog, the cpu_clock code has to be called which could 
> involve multiple cpu locks and can lead to a hard hang if one of the 
> locks is held by a processor that is not going to return anytime soon 
> (such as could be the case with kgdb or perhaps even with some other 
> kind of exception).
> 
> This patch causes the public version of the 
> touch_softlockup_watchdog() to defer the cpu clock access to a later 
> point.

applied to tip/core/softlockup and cherry-picked it into tip/core/urgent 
as well for v2.6.26 merge. Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/