lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 2 Jun 2008 12:41:50 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Abhishek Sagar <sagar.abhishek@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ftrace: distinguish kretprobe'd functions in trace logs


* Steven Rostedt <rostedt@...dmis.org> wrote:

> On Wed, 28 May 2008, Abhishek Sagar wrote:
> >
> > But if irq_enter() has a kretprobe installed on it, the return value stored on the stack at each invocation is modified to divert the return to a kprobe trampoline function called kretprobe_trampoline(). So with this the trace would (currently) look like:
> >
> > <idle>-0     [00] 4154504455.781616: irq_enter <- kretprobe_trampoline
> >
> > Now this is quite misleading to the end user, as it suggests something that didn't actually happen. So just to avoid such misinterpretations, the inlined patch aims to output such a log as:
> >
> > <idle>-0     [00] 4154504455.781616: irq_enter <- [unknown/kretprobe'd]
> >
> >
> > Signed-off-by: Abhishek Sagar <sagar.abhishek@...il.com>
> 
> Thanks Abhishek,
> 
> Acked-by: Steven Rostedt <srostedt@...hat.com>

applied to tip/tracing/ftrace, thanks.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ