lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Jun 2008 14:00:16 +0200 From: Jan Kara <jack@...e.cz> To: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> Cc: akpm@...ux-foundation.org, sct@...hat.com, adilger@...sterfs.com, linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org, jack@...e.cz, jbacik@...hat.com, cmm@...ibm.com, tytso@....edu, sugita <yumiko.sugita.yf@...achi.com>, Satoshi OSHIMA <satoshi.oshima.fk@...achi.com> Subject: Re: [PATCH 3/5] jbd: abort when failed to log metadata buffers On Mon 02-06-08 19:46:02, Hidehiro Kawai wrote: > Subject: [PATCH 3/5] jbd: abort when failed to log metadata buffers > > If we failed to write metadata buffers to the journal space and > succeeded to write the commit record, stale data can be written > back to the filesystem as metadata in the recovery phase. > > To avoid this, when we failed to write out metadata buffers, > abort the journal before writing the commit record. > > Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> Acked-by: Jan Kara <jack@...e.cz> Honza > --- > fs/jbd/commit.c | 3 +++ > 1 file changed, 3 insertions(+) > > Index: linux-2.6.26-rc4/fs/jbd/commit.c > =================================================================== > --- linux-2.6.26-rc4.orig/fs/jbd/commit.c > +++ linux-2.6.26-rc4/fs/jbd/commit.c > @@ -734,6 +734,9 @@ wait_for_iobuf: > /* AKPM: bforget here */ > } > > + if (err) > + journal_abort(journal, err); > + > jbd_debug(3, "JBD: commit phase 6\n"); > > if (journal_write_commit_record(journal, commit_transaction)) > > -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists