[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4843F1B9.7070108@goop.org>
Date: Mon, 02 Jun 2008 14:12:25 +0100
From: Jeremy Fitzhardinge <jeremy@...p.org>
To: Ingo Molnar <mingo@...e.hu>
CC: LKML <linux-kernel@...r.kernel.org>,
xen-devel <xen-devel@...ts.xensource.com>,
Thomas Gleixner <tglx@...utronix.de>,
"Rafael J. Wysocki" <rjw@...k.pl>, x86@...nel.org,
Sam Ravnborg <sam@...nborg.org>
Subject: Re: [bisected] Re: [PATCH 05 of 12] xen: add p2m mfn_list_list
Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@...p.org> wrote:
>
>
>> Subject: make page-aligned data and bss less fragile
>>
>> Making a variable page-aligned by using
>> __attribute__((section(".data.page_aligned"))) is fragile because if
>> sizeof(variable) is not also a multiple of page size, it leaves
>> variables in the remainder of the section unaligned.
>>
>> This patch introduces two new qualifiers, __page_aligned_data and
>> __page_aligned_bss to set the section *and* the alignment of
>> variables. This makes page-aligned variables more robust because the
>> linker will make sure they're aligned properly. Unfortunately it
>> requires *all* page-aligned data to use these macros...
>>
>
> applied to -tip, thanks Jeremy. Created a new topic branch for the core
> bits of it: tip/build. Sam might want to pull from that topic branch
> eventually, once these changes pass testing in -tip.
>
Can you also drop "xen: fix early bootup crash on native hardware" and
replace it with "x86: use __page_aligned_data/bss"? (Which seems to
have been partially applied?)
Thanks,
J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists