linux-kernel - Re: [PATCH] Firmware loader driver for USB Apple iSight camera

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080602192103.GA31589@elte.hu>
Date:	Mon, 2 Jun 2008 21:21:03 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	gregkh@...e.de, bersace03@...oste.net, johannes@...solutions.de
Subject: Re: [PATCH] Firmware loader driver for USB Apple iSight camera


* Matthew Garrett <mjg59@...f.ucam.org> wrote:

> Uninitialised Apple iSight drivers present with a distinctive USB ID. 
> Once firmware has been uploaded, they disconnect and reconnect with a 
> new ID. At this point they can be driven by the uvcvideo driver. As 
> this is unique to the Apple cameras and not functionality shared by 
> any other UVC devices, it makes sense to provide the firmware loading 
> functionality in a separate driver. This driver will read an isight.fw 
> file extracted from the Apple driver using the tools at 
> http://bersace03.free.fr/ift/ and upload it to the camera. It will 
> also handle the case where the device loses its firmware during 
> hibernation and must have it reloaded.

this caused a build failure - find the fix below. (fix can also be 
pulled/cherry-picked from -tip's tip/out-of-tree topic branch)

	Ingo

-------------------->
commit 1f910d33b2084d03267db20359472891f95b45b4
Author: Ingo Molnar <mingo@...e.hu>
Date:   Mon Jun 2 21:07:27 2008 +0200

    USB: fix build bug in USB_ISIGHTFW
    
    -tip tree testing found this build bug:
    
      drivers/built-in.o: In function `isight_firmware_load':
      isight_firmware.c:(.text+0x1ade08): undefined reference to `request_firmware'
      isight_firmware.c:(.text+0x1adf9c): undefined reference to `release_firmware'
    
    select FW_LOADER in USB_ISIGHTFW.

diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
index eb6c069..001789c 100644
--- a/drivers/usb/misc/Kconfig
+++ b/drivers/usb/misc/Kconfig
@@ -272,6 +272,7 @@ config USB_TEST
 config USB_ISIGHTFW
 	tristate "iSight firmware loading support"
 	depends on USB
+	select FW_LOADER
 	help
 	  This driver loads firmware for USB Apple iSight cameras, allowing
 	  them to be driven by the USB video class driver available at
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/