linux-kernel - Re: [PATCH] mm: fix comment formatting in asm-generic/pgtable.h:__ptep_modify_prot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48448807.7020601@goop.org>
Date:	Tue, 03 Jun 2008 00:53:43 +0100
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	x86@...nel.org, xen-devel <xen-devel@...ts.xensource.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Hugh Dickins <hugh@...itas.com>,
	Zachary Amsden <zach@...are.com>,
	kvm-devel <kvm-devel@...ts.sourceforge.net>,
	Virtualization Mailing List <virtualization@...ts.osdl.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] mm: fix comment formatting in asm-generic/pgtable.h:__ptep_modify_prot_

Rusty Russell wrote:
> On Monday 02 June 2008 23:02:34 Jeremy Fitzhardinge wrote:
>   
>> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
>> ---
>>  include/asm-generic/pgtable.h |   14 +++++++++-----
>>  1 file changed, 9 insertions(+), 5 deletions(-)
>>
>> ===================================================================
>> --- a/include/asm-generic/pgtable.h
>> +++ b/include/asm-generic/pgtable.h
>> @@ -201,9 +201,11 @@
>>  					     unsigned long addr,
>>  					     pte_t *ptep)
>>  {
>> -	/* Get the current pte state, but zero it out to make it
>> -	   non-present, preventing the hardware from asynchronously
>> -	   updating it. */
>> +	/*
>> +	 * Get the current pte state, but zero it out to make it
>> +	 * non-present, preventing the hardware from asynchronously
>> +	 * updating it.
>> +	 */
>>     
>
> Since there is debate over whether winged comments are a feature, I'm not sure 
> this can be termed a "fix".
>   

I don't feel all that strongly about it in this case.  I'm not a huge 
fan of winged style for inline comments like this, but it is consistent 
with the rest of the file, and the comment is (just) long enough to make 
it not look completely stupid.

>>  {
>> -	/* The pte is non-present, so there's no hardware state to
>> -	   preserve. */
>> +	/*
>> +	 * The pte is non-present, so there's no hardware state to
>> +	 * preserve.
>> +	 */
>>  	set_pte_at(mm, addr, ptep, pte);
>>  }
>>     
>
> This will fit in one line, no? 
>   

Yes, but changing it would mean going to the effort of regenerating the 
patch.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/