linux-kernel - Re: [PATCH 1/7] add kernel cmdline option to disable pci-irq quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0806031211500.3235@apollo.tec.linutronix.de>
Date:	Tue, 3 Jun 2008 12:13:24 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Olaf Dabrunz <od@...e.de>
cc:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Jon Masters <jonathan@...masters.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Stefan Assmann <sassmann@...e.de>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH 1/7] add kernel cmdline option to disable pci-irq
 quirks

On Mon, 2 Jun 2008, Olaf Dabrunz wrote:
> From: Olaf Dabrunz <od@...e.de>
> 
> Add a switch to disable all boot interrupt quirks, using the parameter
> nobootirqquirk.

This should be a parameter in the form of

pci=ioapicquirk

and not a separate and completely unintuitive thing.

Thanks,
	tglx

> Signed-off-by: Olaf Dabrunz <od@...e.de>
> Signed-off-by: Stefan Assmann <sassmann@...e.de>
> ---
>  drivers/pci/quirks.c |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index dabb563..6245486 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -1363,6 +1363,21 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x2609, quirk_intel_pcie_pm);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x260a, quirk_intel_pcie_pm);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x260b, quirk_intel_pcie_pm);
>  
> +
> +#ifdef CONFIG_X86_IO_APIC
> +int nobootirqquirk __read_mostly = 0;
> +
> +int nobootirqquirk_setup(char *str)
> +{
> +	nobootirqquirk = 1;
> +	printk(KERN_INFO "Boot IRQ quirk handling disabled\n");
> +
> +	return 1;
> +}
> +__setup("nobootirqquirk", nobootirqquirk_setup);
> +#endif /* CONFIG_X86_IO_APIC */
> +
> +
>  /*
>   * Toshiba TC86C001 IDE controller reports the standard 8-byte BAR0 size
>   * but the PIO transfers won't work if BAR0 falls at the odd 8 bytes.
> -- 
> 1.5.2.4
> 
> -- 
> Olaf Dabrunz (od/odabrunz), SUSE Linux Products GmbH, N??rnberg
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/