linux-kernel - Re: [PATCH 6/7] disable pci legacy boot irq quirks on noapic boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0806031254110.3235@apollo.tec.linutronix.de>
Date:	Tue, 3 Jun 2008 12:55:11 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Olaf Dabrunz <od@...e.de>
cc:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Jon Masters <jonathan@...masters.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Stefan Assmann <sassmann@...e.de>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH 6/7] disable pci legacy boot irq quirks on noapic boot

On Mon, 2 Jun 2008, Olaf Dabrunz wrote:

> From: Stefan Assmann <sassmann@...e.de>
> 
> Don't enable pci boot irq quirks when falling back to pic, this would
> break interrupt routing.
> 
> Signed-off-by: Stefan Assmann <sassmann@...e.de>
> Signed-off-by: Olaf Dabrunz <od@...e.de>
> ---
>  include/asm-x86/io_apic.h |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/include/asm-x86/io_apic.h b/include/asm-x86/io_apic.h
> index 5b1292f..461771c 100644
> --- a/include/asm-x86/io_apic.h
> +++ b/include/asm-x86/io_apic.h
> @@ -151,8 +151,11 @@ extern int skip_ioapic_setup;
>  /* 1 if the timer IRQ uses the '8259A Virtual Wire' mode */
>  extern int timer_through_8259;
>  
> +extern int nobootirqquirk;
> +

declarations in headers please.

>  static inline void disable_ioapic_setup(void)
>  {
> +	nobootirqquirk = 1;

This logic needs to be default disabled anyway.

>  	skip_ioapic_setup = 1;
>  }
>  
> -- 
> 1.5.2.4
> 
> -- 
> Olaf Dabrunz (od/odabrunz), SUSE Linux Products GmbH, N??rnberg
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/