linux-kernel - Re: [PATCH 09/10] netns: Enable tagging for net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080603040818.GA18507@suse.de>
Date:	Mon, 2 Jun 2008 21:08:18 -0700
From:	Greg KH <gregkh@...e.de>
To:	Benjamin Thery <benjamin.thery@...l.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Eric Biederman <ebiederm@...ssion.com>,
	Serge Hallyn <serue@...ibm.com>, linux-kernel@...r.kernel.org,
	Tejun Heo <htejun@...il.com>, Al Viro <viro@....linux.org.uk>,
	Daniel Lezcano <dlezcano@...ibm.com>
Subject: Re: [PATCH 09/10] netns: Enable tagging for net_class directories
	in sysfs

On Mon, Jun 02, 2008 at 03:46:08PM +0200, Benjamin Thery wrote:
> net: Enable tagging for net_class directories in sysfs
> 
> The problem.  Network devices show up in sysfs and with the network
> namespace active multiple devices with the same name can show up in
> the same directory, ouch!
> 
> To avoid that problem and allow existing applications in network namespaces
> to see the same interface that is currently presented in sysfs, this
> patch enables the tagging directory support in sysfs.
> 
> By using the network namespace pointers as tags to separate out the
> the sysfs directory entries we ensure that we don't have conflicts
> in the directories and applications only see a limited set of
> the network devices.

I don't like it how the network subsystem is starting to leach into the
sysfs core here.  What happens when the next subsystem wants to do the
same thing?  And then the next one?  Will they all have to do this kind
of intrusive changes to sysfs?

Can't this be done only in the network subsystem?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/