linux-kernel - Re: [PATCH 2/2] bluetooth: hci_bcsp.c small cleanups/api users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1212562424.6339.3.camel@californication>
Date:	Wed, 04 Jun 2008 08:53:44 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] bluetooth: hci_bcsp.c small cleanups/api users

Hi Harvey,

> Use bitrev16 from lib/bitrev.c.
> 
> Use the get_unaligned_be16 to get the crc from the packet, create a
> small helper function for this.
> 
> Fix a shadowed variable sparse warning:
> drivers/bluetooth/hci_bcsp.c:218:26: warning: symbol 'hdr' shadows an earlier one
> drivers/bluetooth/hci_bcsp.c:187:5: originally declared here
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>

Acked-by: Marcel Holtmann <marcel@...tmann.org>

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/