linux-kernel - Re: [PATCH] cgroup: list_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 Jun 2008 18:20:18 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	"Paul Menage" <menage@...gle.com>
Cc:	kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org,
	"Li Zefan" <lizf@...fujitsu.com>
Subject: Re: [PATCH] cgroup: list_for_each cleanup

> > -       while (!list_empty(&release_list)) {
> > +
> > +       list_for_each_entry_safe(cgrp, saved_cgrp, &release_list,
> > +                                release_list) {
> >                char *argv[3], *envp[3];
> >                int i;
> >                char *pathbuf;
> > -               struct cgroup *cgrp = list_entry(release_list.next,
> > -                                                   struct cgroup,
> > -                                                   release_list);
> > +
> 
> I don't think that list_for_each_entry_safe() is still safe when we've
> dropped release_list_lock. saved_cgroup could end up pointing to a
> cgroup that's freed while we're forking the usermode helper.

Ah, you are right.
I'll drop this portion and resend patch.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/