linux-kernel - Re: [linux-pm] [PATCH] add a printk_init variant storing format strings in _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1212576668.14371.21.camel@johannes.berg>
Date:	Wed, 04 Jun 2008 12:51:08 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, pavel@...e.cz,
	Andy Whitcroft <apw@...dowen.org>, mingo@...e.hu,
	linux-pm@...ts.linux-foundation.org
Subject: Re: [linux-pm] [PATCH] add a printk_init variant storing format
	strings in	__initdata

On Wed, 2008-06-04 at 10:17 +0100, David Woodhouse wrote:
> On Wed, 2008-06-04 at 11:10 +0200, Johannes Berg wrote:
> > On Wed, 2008-06-04 at 09:59 +0100, David Woodhouse wrote:
> > > On Wed, 2008-06-04 at 01:16 -0700, Andrew Morton wrote:
> > > > We're going to want to be able to call printk_init() from modules. 
> > > > Please fix and test that, if we decide to proceed.
> > > 
> > > Can we fix that by making it an alias for printk in the module case?
> > > 
> > > The only reason we need it to be __init is so that we get the section
> > > warnings when you use it from non-init code, right? Won't we get the
> > > warning when non-init code refers to the string in initdata anyway?
> > 
> > In fact, wasn't the warning Andy showed such a warning?
> 
> Hm, yes it was. Why do we need __printk_init() to be anything other than
> an alias for printk, then?

It looks to me like we wouldn't need it at all, just the printk_init()
macro that puts the format string into the right section.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)