linux-kernel - Re: [PATCH] console - Add configurable support for console charset translation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080604125500.0fce2ea4@core>
Date:	Wed, 4 Jun 2008 12:55:00 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Tim Bird <tim.bird@...sony.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	linux-tiny <Linux-tiny@...enic.com>,
	linux-embedded <linux-embedded@...r.kernel.org>,
	linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] console - Add configurable support for console charset
 translation

> This is clearly an improvement. But it is missing this part of the
> original patch:
> 
> --- a/drivers/char/vt.c
> +++ b/drivers/char/vt.c
> @@ -2198,7 +2198,11 @@ rescan_last_byte:
>  			c = 0xfffd;
>  		    tc = c;
>  		} else {	/* no utf or alternate charset mode */
> +#ifdef CONFIG_CONSOLE_TRANSLATIONS
>  		    tc = vc->vc_translate[vc->vc_toggle_meta ? (c | 0x80) : c];
> +#else
> +		    tc = c;
> +#endif

Can we please get the ifdefs tided up before this goes in.

For the moment this has a NAK from the tty maintainer but if the ifdefs
turned went into headers where they belong and the code looked like say

		tc = vc_translate(vc, c);

with two versions of vc_translate (one being vc_translate(x) (x)) it
might be more reasonable.

We can't stick random ifdefs in bits of code for arbitary 6K savings or
the entire kernel would be ifdefs.


Sor for the moment

Nacked-by: Alan Cox <alan@...hat.com>

but scope for change
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/