linux-kernel - Re: [PATCH] quota: Split out quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080604135624.GA13683@cs181133002.pp.htv.fi>
Date:	Wed, 4 Jun 2008 16:56:24 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Jan Kara <jack@...e.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] quota: Split out quota_struct.h out of quota.h

On Mon, Jun 02, 2008 at 07:11:10PM +0200, Jan Kara wrote:
> Split some structure definitions from quota.h to quota_struct.h so that they
> can be separately included in fs.h. This makes it possible to declare some
> useful inline functions in quota.h because it can now include fs.h.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>
> ---
>  include/linux/fs.h       |    2 +-
>  include/linux/quota.h    |  193 +---------------------------------------------
>  include/linux/quotaops.h |    1 +
>  include/linux/syscalls.h |    2 +-
>  4 files changed, 5 insertions(+), 193 deletions(-)
>...

Missing "git-add include/linux/quota_struct.h" ?

> --- a/include/linux/quota.h
> +++ b/include/linux/quota.h
> @@ -37,13 +37,11 @@
>  
>  #include <linux/errno.h>
>  #include <linux/types.h>
> +#include <linux/quota_struct.h>
>...

This breaks our userspace headers.

Please always run "make headers_check" after touching #include's
under include/

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/